Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker][docs]Deploy Sylius with Docker #14051

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Jun 2, 2022

Introduction

Wait for #14023

Installation

Screenshot 2022-06-02 at 17 57 23

Installation with Docker

Screenshot 2022-06-02 at 17 57 53

Screenshot 2022-06-02 at 17 58 09

Deploy with Docker

Screenshot 2022-06-08 at 17 52 39

Screenshot 2022-06-08 at 17 52 51

Deployment

Screenshot 2022-06-08 at 17 53 41

@Ferror Ferror requested a review from a team as a code owner June 2, 2022 13:45
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jun 2, 2022
@probot-autolabeler probot-autolabeler bot added Docker Docker-related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Jun 2, 2022
docs/getting-started-with-sylius/deployment.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/docker.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/docker.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/docker.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/docker.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/docker.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/docker.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/docker.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/docker.rst Outdated Show resolved Hide resolved
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor fixes and ready to go! 🚀

docs/book/installation/installation_with_docker.rst Outdated Show resolved Hide resolved
docs/book/installation/installation_with_docker.rst Outdated Show resolved Hide resolved
docs/book/installation/installation_with_docker.rst Outdated Show resolved Hide resolved
docs/getting-started-with-sylius/deployment.rst Outdated Show resolved Hide resolved

.. tip::

- 👉 :doc:`How to deploy Sylius to Platform.sh? </cookbook/deployment/platform-sh>`
- 👉 :doc:`How to deploy Sylius to Symfony Cloud? </cookbook/deployment/cloudways>`
- 👉 :doc:`How to deploy Sylius to Artifakt? </cookbook/deployment/symfonycloud>`
- 👉 :doc:`How to deploy Sylius to Cloudways? </cookbook/deployment/artifakt>`
- 🐳 :doc:`How to deploy Sylius with Docker </cookbook/deployment/docker>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ the 🐳 !

Comment on lines +21 to +22

Sylius Standard comes with the `multi-stage build <https://docs.docker.com/develop/develop-images/multistage-build/>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a multistage build already? I thought that it is plan for the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it in Sylius-Standard :)


.. code-block:: bash

export MYSQL_PASSWORD=SLyPJLaye7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be somehow generated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be defined by user, but in this fast route of deployment, I had to somehow define it. The root password is randomly generated, but users have to be defined. The ideal scenario states that User would use Managed DB, and the problem would not exist :)

@lchrusciel lchrusciel merged commit 59ebc5c into Sylius:master Jul 5, 2022
@Ferror Ferror deleted the docker-docs branch July 5, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Docker-related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants