[Admin][Zones] Choosing disabled country as a zone member made possible for admin user

[TheMilek]

Q	A
Branch?	1.11
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

Right now we’re experiencing a bug-o-feature, where when you disable a country that is a zone member, the members list on the Zone shows empty dropdown and field is unable to be controlled.

Changes made:

• adding disabled countries as zone members made possible for admin users
• search dropdown added instead of select dropdown field

Before:

After:

[GSadee]

I can add here almost the same comment as in the previous iteration: #14058 (comment)

CountryCodeChoiceType is used in several different places if I'm correct, but you want to change the behaviour only for selecting countries for zones, so this parameter should be disabled only in ZoneType, at least for now

[TheMilek]

We can't resolve it in ZoneType as it is only parent of members and we need to add enabled key to his child code - sorry for not letting you know in the previous comment. Yeah, but you are right, CountryCodeChoiceType has impact on other forms as it is in CountryChoiceType - I must have missed it. I decided to make custom form type here that is only referencing code child field in zoneMembers form. What do you think about it? CountryCodeChoiceType and CountryChoiceType can be then used anywhere else and we still achieve wanted behavior

[GSadee]

I'm almost sure that if you will change this line: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/AddressingBundle/Form/Type/ZoneType.php#L104 by adding there an enabled parameter, it will work correctly:

ZoneInterface::TYPE_COUNTRY => ['label' => 'sylius.form.zone.types.country', 'enabled' => false],

And you will not need to add a custom form type. Did you check this approach?

[GSadee]

Thank you, Kamil! 🎉