[Addressing] Enable orphan removal for zone members #14059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
force-pushed
the
fix/zone-members-orphan-removal
branch
2 times, most recently
from
dea3359
to
43f8b39
Compare
coldic3
force-pushed
the
fix/zone-members-orphan-removal
branch
from
43f8b39
to
4332225
Compare
CoderMaggie
reviewed
Jun 7, 2022
features/addressing/managing_countries/managing_provinces_of_country.feature
Outdated
Show resolved
Hide resolved
features/addressing/managing_countries/managing_provinces_of_country.feature
Outdated
Show resolved
Hide resolved
features/addressing/managing_countries/managing_provinces_of_country.feature
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
Jun 7, 2022
features/addressing/managing_countries/managing_provinces_of_country.feature
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
fix/zone-members-orphan-removal
branch
from
4332225
to
47fef6e
Compare
GSadee
approved these changes
Jun 8, 2022
|
Thanks, Kevin! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without orphan removal, even if we delete the zone member, the corresponding province/country cannot be removed because orphans still exist in the database.