[Addressing] Fix adding and removing zone members again #14061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coldic3
commented
Jun 7, 2022
•
coldic3
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #13701 |
| License | MIT |
coldic3
force-pushed
the
fix/removing-and-adding-zone-members-again-s2
branch
from
9f62baf
to
97ee9d7
Compare
coldic3
force-pushed
the
fix/removing-and-adding-zone-members-again-s2
branch
from
97ee9d7
to
cd1a165
Compare
Zales0123
reviewed
Jun 7, 2022
src/Sylius/Bundle/AddressingBundle/spec/Form/EventListener/BuildZoneFormSubscriberSpec.php
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
fix/removing-and-adding-zone-members-again-s2
branch
from
cd1a165
to
944431e
Compare
coldic3
changed the title
coldic3
force-pushed
the
fix/removing-and-adding-zone-members-again-s2
branch
2 times, most recently
from
93106c3
to
5c0f5fa
Compare
GSadee
reviewed
Jun 8, 2022
src/Sylius/Bundle/AddressingBundle/Form/EventListener/BuildZoneFormSubscriber.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AddressingBundle/Form/EventListener/BuildZoneFormSubscriber.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AddressingBundle/Resources/config/services/form.xml
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
fix/removing-and-adding-zone-members-again-s2
branch
from
5c0f5fa
to
891a1a9
Compare
coldic3
force-pushed
the
fix/removing-and-adding-zone-members-again-s2
branch
from
891a1a9
to
71d72ec
Compare
GSadee
approved these changes
Jun 9, 2022
| /** | ||
| * @Transform /^"([^"]+)", "([^"]+)" and "([^"]+)" country members$/ | ||
| */ | ||
| public function getCountryTypeZoneMembersByNames(string ...$name): array |
There was a problem hiding this comment.
Suggested change
| public function getCountryTypeZoneMembersByNames(string ...$name): array | |
| public function getCountryTypeZoneMembersByNames(string ...$names): array |
|
Thank you, Kevin! 🥇 |
GSadee
added a commit
that referenced
this pull request
Jun 9, 2022
…ith API coverage only) (coldic3) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11| | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | fixes #13701 | | License | MIT | This PR should be merged after #14061. Commits ------- 34dc891 [Addressing][Behat] Add scenario for removing and adding zone members again 62f3d5c [Addressing] Add ZoneDenormalizer
GSadee
added a commit
that referenced
this pull request
Jun 10, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | refactoring of #14061, #14067 | | License | MIT | Commits ------- 6953125 [Addressing] Minor refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.