[Template][Events] Part of new UI bundle events for security and grid #14101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ernestWarwas
commented
Jun 22, 2022
ernestWarwas
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
GSadee
reviewed
Jun 23, 2022
src/Sylius/Bundle/UiBundle/Resources/views/Security/_login.html.twig
Outdated
Show resolved
Hide resolved
ernestWarwas
force-pushed
the
ui-plus-events
branch
from
1243098
to
b0cf8fe
Compare
GSadee
approved these changes
Jun 23, 2022
lchrusciel
reviewed
Jun 23, 2022
src/Sylius/Bundle/UiBundle/Resources/views/Grid/_content.html.twig
Outdated
Show resolved
Hide resolved
| {% endif %} | ||
| {{ pagination.simple(data) }} | ||
| </div> | ||
| {{ sylius_template_event('sylius.admin.grid.content', _context) }} |
There was a problem hiding this comment.
We could think about more then one event being triggered here, like generic grid, admin/shop and resource if exists. You may check how it may be done here for example here: src/Sylius/Bundle/AdminBundle/Resources/views/Crud/create.html.twig
There was a problem hiding this comment.
Ok, I will do it in separate PR 😃
ernestWarwas
force-pushed
the
ui-plus-events
branch
from
0a8143c
to
ecd8588
Compare
lchrusciel
reviewed
Jun 23, 2022
ernestWarwas
force-pushed
the
ui-plus-events
branch
from
04e5f6e
to
de07e48
Compare
[Template][Events] Changed names of events [Template][Events] Changed names of events [Template][Events] Changed names of events order changed fix BC fix render rest
ernestWarwas
force-pushed
the
ui-plus-events
branch
from
76d8d76
to
76208b4
Compare
lchrusciel
approved these changes
Jun 23, 2022
lchrusciel
added
DX
GSadee
approved these changes
Jun 23, 2022
Zales0123
approved these changes
Jun 23, 2022
|
Thanks, Ernest! 🎉 |
lchrusciel
reviewed
Jun 24, 2022
Comment on lines
+239
to
+261
| sylius.grid: | ||
| blocks: | ||
| content: | ||
| template: "@SyliusUi/Grid/_content.html.twig" | ||
| priority: 10 | ||
|
|
||
| sylius.grid.body: | ||
| blocks: | ||
| navigation: | ||
| template: "@SyliusUi/Grid/Body/_navigation.html.twig" | ||
| priority: 30 | ||
| table: | ||
| template: "@SyliusUi/Grid/Body/_table.html.twig" | ||
| priority: 20 | ||
| pagination: | ||
| template: "@SyliusUi/Grid/Body/_pagination.html.twig" | ||
| priority: 10 | ||
|
|
||
| sylius.grid.filters: | ||
| blocks: | ||
| content: | ||
| template: "@SyliusUi/Grid/Filter/_content.html.twig" | ||
| priority: 10 |
There was a problem hiding this comment.
These configs have to go to UiBundle
Zales0123
added a commit
that referenced
this pull request
Jun 24, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11| | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no| | Related tickets | fixes #14101 | License | MIT | <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 58e66f9 [Templates] Move grid events to UI bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.