[Maintenance] Composer allow plugins finally sorted out + removal of symfony thanks #14106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvasiloi
approved these changes
Jun 22, 2022
loic425
approved these changes
Jun 22, 2022
GSadee
approved these changes
Jun 22, 2022
GSadee
added
Maintenance
|
Thanks, Łukasz! 🎉 |
This was referenced Jul 4, 2022
Zales0123
added a commit
to Sylius/SyliusThemeBundle
that referenced
this pull request
Jul 4, 2022
…lchrusciel) This PR was merged into the 2.2-dev branch. Discussion ---------- Follow up of Sylius/Sylius#14106 Commits ------- 3b829a7 [Maintenance] Allow flex plugin during plugin installation
Zales0123
added a commit
to Sylius/AdminOrderCreationPlugin
that referenced
this pull request
Jul 4, 2022
…lchrusciel) This PR was merged into the 1.1-dev branch. Discussion ---------- Follow up of Sylius/Sylius#14106 Commits ------- 550daa6 [Maintenance] Allow flex plugin during plugin installation
Zales0123
added a commit
to Sylius/SyliusMailerBundle
that referenced
this pull request
Jul 4, 2022
…lchrusciel) This PR was merged into the 1.7 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Follow up of Sylius/Sylius#14106 | License | MIT Commits ------- 6125949 [Maintenance] Allow flex plugin during plugin installation
mamazu
added a commit
to Sylius/ShopApiPlugin
that referenced
this pull request
Jul 4, 2022
…lchrusciel) This PR was merged into the 1.0-dev branch. Discussion ---------- Follow up of Sylius/Sylius#14106 Commits ------- 1759c16 [Maintenance] Allow flex plugin during plugin installation
AdamKasp
added a commit
to Sylius/RefundPlugin
that referenced
this pull request
Jul 5, 2022
…on (lchrusciel) This PR was merged into the 1.2 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.2 | Bug fix? | yes | New feature? | no | Related tickets | Follow up of Sylius/Sylius#14106 Commits ------- c748740 [Maintenance] Allow flex plugin during plugin installation
AdamKasp
added a commit
to Sylius/InvoicingPlugin
that referenced
this pull request
Jul 5, 2022
…on (lchrusciel) This PR was merged into the 1.0-dev branch. Discussion ---------- Follow up of Sylius/Sylius#14106 Commits ------- 16dbb10 [Maintenance] Allow flex plugin during plugin installation
Zales0123
added a commit
to Sylius/SyliusResourceBundle
that referenced
this pull request
Jul 6, 2022
…lchrusciel) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Follow up of Sylius/Sylius#14106 | License | MIT Commits ------- 93be49c [Maintenance] Allow flex plugin during plugin installation aa3cda7 [Maintenance] Execution of easy-coding-standard a1a14b2 [Conflict] Add note about phpstan/phpdoc-parser f5195bb [Maintenance] Bump PHPStan and solve newly found issues
lchrusciel
added a commit
to Sylius/SyliusGridBundle
that referenced
this pull request
Jul 6, 2022
…lchrusciel) This PR was merged into the 1.11 branch. Discussion ---------- Follow up of Sylius/Sylius#14106 Commits ------- d17f19c [Maintenance] Allow flex plugin during plugin installation 7ecbd85 [GitHub] Do not ignore platform version of PHP in GitHub action 82bf60a [Maintenance] Execution of easy-coding-standard
Zales0123
added a commit
to Sylius/PayPalPlugin
that referenced
this pull request
Jul 12, 2022
…pdated GitHub workflow (Rafikooo) This PR was merged into the 1.4 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.4 (bug fixes, improvements) | Bug fix? | no | New feature? | no https://getcomposer.org/doc/06-config.md#allow-plugins "As of Composer 2.2.0, the allow-plugins option adds a layer of security allowing you to restrict which Composer plugins are able to execute code during a Composer run." 1. Due to the fact above the configuration of composer.json has been updated to process dependencies explicitly 2. Conflict with `doctrine/orm:^2.10.0` has been removed 3. Conflict with `doctrine/dbal:^3.0.0` has been added 4. GitHub workflow has been updated based on https://github.com/Sylius/Sylius/pull/14130/files#diff-dc5f32521b4ae99ff8632eb151f06cb36a62fe139292cbbf3f2a4afc79647581 and Sylius/Sylius#14106 Commits ------- 7ec43fd [Maintenance] Removed conflict with doctrine/orm ^2.10.0 310d996 [Maintenance] Allow-plugins config section added 34fce46 [GithubActions] Updated section Restrict Symfony version 278d43c [Maintenance] Added conflict with doctrine/dbal:^3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing adding flex to our allowed plugins, as we are using it and it is in our req/dev. In addition, I've also disallowed
dealerdirect/phpcodesniffer-composer-installer, as we are not using it directly.What is more, I'm proposing the removal of
symfony/thankslib, as it does not provide valuable features and is not present in any Symfony package anymore. We are the main package that still installs it https://packagist.org/packages/symfony/thanks/dependents?order_by=downloads&requires=all. Let's give it rest.These plugins are executed by default right now, but this behaviour will change since the beginning of July. If we don't do anything we can expect the following error:
Once merged, we should iterate over our other packages.