[BUG] The hostname resolver does not check for the channel status #14155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
Maintenance
lchrusciel
reviewed
Jul 15, 2022
src/Sylius/Component/Channel/Repository/ChannelRepositoryInterface.php
Outdated
Show resolved
Hide resolved
|
@lchrusciel I've changed a little the scenario to add API easier. I hope it still sounds good :). |
NoResponseMate
approved these changes
Jul 18, 2022
src/Sylius/Behat/Resources/config/suites/api/channel/channels.yml
Outdated
Show resolved
Hide resolved
Zales0123
approved these changes
Jul 18, 2022
| */ | ||
| public function iShouldNotSeeProduct(string $productName): void | ||
| { | ||
| Assert::true(!in_array($productName, $this->homePage->getLatestProductsNames())); |
There was a problem hiding this comment.
I'm genuinely surprised there is no Assert::notInArray 😱
|
Thank you, Jakub! 🎉 |
This was referenced Jul 19, 2022
coldic3
added a commit
that referenced
this pull request
Nov 29, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11| | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no| | Related tickets | after #14155 | License | MIT | <!-- - Bug fixes must be submitted against the 1.11 or 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 19db727 [Behat][API] Add missing channels suite to imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done:
UPGRADE-1.11.mdand theUPGRADE-1.10.mdfilesWe've had a discussion about parametrizing the
HostnameBasedRequestResolver(what I've done btw 😂) but we decided to drop that idea and keep the original concept.Thank you @lruozzi9 for your PR we could base on :).