Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]Send request to GUS with https #14213

Merged
merged 1 commit into from
Aug 2, 2022
Merged

[bug]Send request to GUS with https #14213

merged 1 commit into from
Aug 2, 2022

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Aug 1, 2022

Q A
Branch? 1.9, 1.10, 1.11, 1.12
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Due to the change of the GUS deployment to Digital Ocean Apps - there is no longer a need to keep the URL as HTTP. We cannot keep it SSL free, as Digital Ocean enforces HTTPS. The real problem occurred because locally it saves website statistics, but with ex. a Postman - The redirect is present, and even with the "allow_redirect" parameter by Guzzle the Website does not hold, yet returns proper Sylius Version.

Without SSL

Screenshot 2022-08-01 at 16 47 01

## With SSL

Screenshot 2022-08-01 at 16 59 31

@Ferror Ferror requested a review from a team as a code owner August 1, 2022 14:58
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Aug 1, 2022
@GSadee GSadee changed the base branch from 1.12 to 1.11 August 2, 2022 04:45
@GSadee
Copy link
Member

GSadee commented Aug 2, 2022

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "gus-ssl" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Aug 2, 2022
@GSadee GSadee merged commit f0df6a8 into Sylius:1.11 Aug 2, 2022
@GSadee
Copy link
Member

GSadee commented Aug 2, 2022

Thanks, Zbigniew! 🎉

@Ferror Ferror deleted the gus-ssl branch September 14, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants