Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add info about mailer in installation doc #14247

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Aug 21, 2022

Q A
Branch? 1.12
License MIT

@arti0090 arti0090 requested a review from a team as a code owner August 21, 2022 09:35
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Aug 21, 2022
docs/book/installation/installation.rst Outdated Show resolved Hide resolved
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be a little bit outdated, probably it should be merged to the 1.11 branch in this version and be updated in 1.12 because of the PR

@GSadee GSadee changed the base branch from 1.12 to 1.11 October 10, 2022 09:00
@GSadee
Copy link
Member

GSadee commented Oct 10, 2022

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "mailer-install" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we should already update this doc for 1.12 and Symfony Mailer

@lchrusciel lchrusciel merged commit 0c70011 into Sylius:1.11 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants