Prevent eager loading hundreds of countries #14286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The broken tests seems not related to the changes, not sure what are they about. |
|
@kayue those are related to the recent deprecations in Symfony Mailer. A new version was tagged less than an hour before your PR: https://github.com/Sylius/SyliusMailerBundle/releases/tag/v1.8.0 |
|
Rebasing this branch and hopefully tests will pass this time. This change is working in my local project so I am confident that it will pass the tests. |
|
All tests are passing now, thanks. |
coldic3
added
the
Enhancement
probot-autolabeler
bot
added
Docker
NoResponseMate
removed
Documentation
vvasiloi
approved these changes
Dec 1, 2023
jakubtobiasz
force-pushed
the
patch-27
branch
from
2b5c0e4
to
1a3068a
Compare
Bunnyshell Preview Environment deletedAvailable commands:
|
NoResponseMate
approved these changes
Dec 7, 2023
diimpp
approved these changes
Dec 7, 2023
jakubtobiasz
approved these changes
Dec 12, 2023
jakubtobiasz
approved these changes
Dec 12, 2023
|
Thank you, @kayue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eager loading all countries would add extra 8ms - 10ms overhead to Sylius' boot up time. Creating a draft PR to see what test case would it break first.