[Admin] Improve highlighting menu items #14324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
added
UX
Comment on lines
+52
to
+55
| ->addChild('taxons', ['route' => 'sylius_admin_taxon_create', 'extras' => ['routes' => [ | ||
| ['route' => 'sylius_admin_taxon_create_for_parent'], | ||
| ['route' => 'sylius_admin_taxon_update'], | ||
| ]]]) |
There was a problem hiding this comment.
Couldn't you use the ::setExtra method instead?
There was a problem hiding this comment.
I thought about that, but it doesn't work, I'm not sure why and haven't searched deeper 🤷🏻
There was a problem hiding this comment.
Could you recheck, because I just added
->setExtra('routes', [
['route' => 'sylius_admin_taxon_create'],
['route' => 'sylius_admin_taxon_create_for_parent'],
['route' => 'sylius_admin_taxon_update'],
])and it seems to work just fine.
There was a problem hiding this comment.
Ok, I see the difference, you are passing also the "main" route to extras, which I didn't do, so this approach requires duplication of one route in each menu item, now, I'm not sure if it looks better 😄
GSadee
force-pushed
the
admin-improve-menu
branch
from
4b09db7
to
46bd86e
Compare
lchrusciel
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples:
Before:
After:
