[Template][Events] Introduce Context Providers for Template Blocks #14328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
force-pushed
the
feature/extensible-template-events-context
branch
3 times, most recently
from
0a4334e
to
535d83c
Compare
coldic3
added
Feature
Zales0123
reviewed
Sep 20, 2022
src/Sylius/Bundle/UiBundle/Renderer/TwigTemplateBlockRenderer.php
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
feature/extensible-template-events-context
branch
from
535d83c
to
35eaf40
Compare
probot-autolabeler
bot
added
Admin
coldic3
force-pushed
the
feature/extensible-template-events-context
branch
from
35eaf40
to
ec2b0c9
Compare
coldic3
changed the title
coldic3
changed the title
GSadee
reviewed
Sep 22, 2022
Comment on lines
+18
to
+20
| /** | ||
| * @experimental | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @experimental | |
| */ | |
| /** @experimental */ |
There was a problem hiding this comment.
I forgot to refactor it but in the next PR, I will completely remove @experimental tags so I would be for leaving it as it is for now.
src/Sylius/Bundle/UiBundle/ContextProvider/LegacySonataEventContextProvider.php
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
feature/extensible-template-events-context
branch
from
ec2b0c9
to
ff89aa2
Compare
GSadee
approved these changes
Sep 23, 2022
|
Thank you, Kevin! 🎉 |
GSadee
added a commit
that referenced
this pull request
Sep 28, 2022
…tion guide (coldic3) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | #14328 | | License | MIT |    Commits ------- 0ff9022 [Docs] Add Context Providers to the template customization guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Sylius\Bundle\UiBundle\Block\BlockEventListeneris deprecated, there is no easy way to add additional data to the template context before rendering. This PR introducesContextProviderInterfacethat allows you to implement your own Context Provider for template blocks.