Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat][PostgreSQL] Fix removing items from cart #14344

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Sep 22, 2022

Q A
Branch? 1.12
Bug fix? yes?
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #14336
License MIT

It is a little bit strange to me, because the build was green (yesterday) in PR with enabling Behat tests for Postgres, but it seems that this scenario is failing (randomly?) because of the different order of items compared to MySQL. As I've reproduced that locally, I was able to fix that 😃

Failing build: https://github.com/Sylius/Sylius/actions/runs/3099676219/jobs/5026644424#step:26:517

@GSadee GSadee added Behat Issues and PRs aimed at improving Behat usage. Bug Confirmed bugs or bugfixes. labels Sep 22, 2022
@GSadee GSadee requested a review from a team as a code owner September 22, 2022 09:15
@Zales0123 Zales0123 merged commit a071bc5 into Sylius:1.12 Sep 22, 2022
@Zales0123
Copy link
Member

Thanks, Grzegorz! 🎉

@GSadee GSadee deleted the postgres-fix branch September 22, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Behat Issues and PRs aimed at improving Behat usage. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants