Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Products][Admin][UI] Display the channel name instead of the channel code in the variant list #14377

Merged
merged 1 commit into from
Sep 29, 2022
Merged

[Products][Admin][UI] Display the channel name instead of the channel code in the variant list #14377

merged 1 commit into from
Sep 29, 2022

Conversation

Rafikooo
Copy link
Contributor

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT
Before:

image

After:

image

In the simple product show, we also display the translated name

@Rafikooo Rafikooo requested a review from a team as a code owner September 28, 2022 14:02
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Sep 28, 2022
@Rafikooo Rafikooo added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Bug Confirmed bugs or bugfixes. and removed Admin AdminBundle related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Sep 28, 2022
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Sep 28, 2022
@GSadee GSadee merged commit fccd17d into Sylius:1.11 Sep 29, 2022
@GSadee
Copy link
Member

GSadee commented Sep 29, 2022

Thanks, Rafał! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@vvasiloi vvasiloi vvasiloi approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rafikooo @GSadee @vvasiloi @NoResponseMate