Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ramsey/uuid ^4.0 to avoid PHP 8.1 warning #14398

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Allow ramsey/uuid ^4.0 to avoid PHP 8.1 warning #14398

merged 2 commits into from
Oct 4, 2022

Conversation

vasilvestre
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

There's a type error in 8.1 due to return type.
Error: During inheritance of JsonSerializable: Uncaught Behat\\Testwork\\Call\\Exception\\CallErrorException: 8192: Return type of Ramsey\\Uuid\\Uuid::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \/var\/www\/html\/vendor\/ramsey\/uuid\/src\/Uuid.php line 216

@vasilvestre vasilvestre requested a review from a team as a code owner October 3, 2022 11:41
@loic425 loic425 marked this pull request as draft October 3, 2022 11:50
@Zales0123
Copy link
Member

Zales0123 commented Oct 4, 2022

There is plenty of such PRs already opened 😅 Let's finally do something with it 💪

@Zales0123 Zales0123 marked this pull request as ready for review October 4, 2022 10:17
@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Oct 4, 2022
@Zales0123 Zales0123 merged commit ca6ff4d into Sylius:1.12 Oct 4, 2022
@Zales0123
Copy link
Member

Thank you, Valentin! 🥇

@Zales0123
Copy link
Member

Thank you also @jeremyFreeAgent (#12809), @esserj (#14109) and @ancarda (#14317) 🖖

@vasilvestre
Copy link
Contributor Author

vasilvestre commented Oct 4, 2022

Thank you also @jeremyFreeAgent (#12809), @esserj (#14109) and @ancarda (#14317) vulcan_salute

Oh no, this is a draft, my change only allows ^4.0 and doesn't allow ^3.9 anymore.
It's an abrupt change IMHO. I think ^3.9 || ^4.0 would be better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants