[API][Behat] Add note about behat request changes #14443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Oct 14, 2022
TheMilek
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | mentioned in #Z |
| License | MIT |
probot-autolabeler
bot
added
the
Maintenance
GSadee
reviewed
Oct 17, 2022
TheMilek
force-pushed
the
api-requests-refactor-documented
branch
from
83b4d63
to
7a788f5
Compare
coldic3
reviewed
Oct 17, 2022
| } | ||
|
|
||
| if ($method === HttpRequest::METHOD_PUT) { | ||
| return self::LINKED_DATA_JSON_CONTENT_TYPE; |
There was a problem hiding this comment.
Not related to this PR but I don't get why we use JSON-LD only for PUT methods 🤔
TheMilek
force-pushed
the
api-requests-refactor-documented
branch
from
7a788f5
to
98f4d94
Compare
coldic3
approved these changes
Oct 17, 2022
GSadee
approved these changes
Oct 17, 2022
|
Thank you, Kamil! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.