Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade gaufrette version (PHP 8+ compat) #14474

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

Nek-
Copy link
Contributor

@Nek- Nek- commented Oct 21, 2022

Q A
Branch? 1.11
Bug fix? no
New feature? yes
BC breaks? no/yes
Deprecations? no
Related tickets none
License MIT

Hello, I worked on Gaufrette for supporting PHP 8.0 and 8.1. It's only supported in newer versions of Gaufrette.

Please notice there are some BC breaks in Gaufrette (we're talking about major version upgrade here) but it's actually really limited:

  • Classes are now typed (and it should not impact many people, it does not impact sylius)
  • Google Adapter use the new major version of the google library (which is compatible with PHP 8+)

I know you did an effort to remove Gaufrette (and you did right because gaufrette is end of life and will not be compatible with new versions of PHP and new external libraries) but I think allowing people to have a version compatible with their own PHP version is great.

@Nek- Nek- requested a review from a team as a code owner October 21, 2022 16:23
@coldic3 coldic3 changed the base branch from 1.10 to 1.11 November 24, 2022 10:33
@coldic3
Copy link
Contributor

coldic3 commented Nov 24, 2022

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "feat/gaufrette-php-8" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Nek-
Copy link
Contributor Author

Nek- commented Nov 24, 2022

@coldic3 it seems like everything is still ok and the merge can be done. I will rebase tomorrow if you absolutely want it.

@jakubtobiasz
Copy link
Contributor

@Nek- you don't need to do anything. @coldic3 message is auto-generated by hubkit as you opened your PR against 1.10 which is unsupported. He just changed the base to 1.11.

@Rafikooo Rafikooo merged commit 5f1707e into Sylius:1.11 Nov 29, 2022
@Rafikooo
Copy link
Contributor

Thanks, Maxime! 🎉

@Nek- Nek- deleted the feat/gaufrette-php-8 branch November 29, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants