Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat][API] Add missing channels suite to imports #14514

Merged
merged 1 commit into from
Nov 29, 2022
Merged

[Behat][API] Add missing channels suite to imports #14514

merged 1 commit into from
Nov 29, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Nov 3, 2022

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets after #14155
License MIT

@GSadee GSadee added Behat Issues and PRs aimed at improving Behat usage. API APIs related issues and PRs. Bug Confirmed bugs or bugfixes. labels Nov 3, 2022
@GSadee GSadee requested a review from a team as a code owner November 3, 2022 12:14
@TheMilek TheMilek changed the base branch from 1.13 to 1.11 November 23, 2022 23:15
@coldic3 coldic3 merged commit ed7df7a into Sylius:1.11 Nov 29, 2022
@coldic3
Copy link
Contributor

coldic3 commented Nov 29, 2022

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the behat-api-channels-suites branch November 29, 2022 07:52
@Rafikooo Rafikooo mentioned this pull request Nov 30, 2022
Merged
GSadee added a commit that referenced this pull request Dec 1, 2022
@GSadee
bug #14595 [Fix] Filtering out disabled channel scenario (Rafikooo)
7f07acf 
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11 <!-- see the comment below -->                  |
| Bug fix?        | yes                                                       |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | no<!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes #14514
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.11 or 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

e763161 [Behat] Missing disabled channel filtering step implementation
5eeb42a [Behat][Channel] Setup hostname in a shared storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@coldic3 coldic3 coldic3 approved these changes

@TheMilek TheMilek TheMilek approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Behat Issues and PRs aimed at improving Behat usage. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GSadee @coldic3 @NoResponseMate @TheMilek