Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS][DX] Fix ECS refactoring #14570

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[CS][DX] Fix ECS refactoring #14570

merged 2 commits into from
Dec 5, 2022

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Nov 23, 2022

Q A
Branch? 1.11
Bug fix? yes, fixes GH workflow
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes https://github.com/Sylius/Sylius/actions/runs/3510976282/jobs/5881301730#step:5:1449
License MIT

@coldic3 coldic3 requested a review from a team as a code owner November 23, 2022 10:29
@coldic3 coldic3 added DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc. labels Nov 23, 2022
@probot-autolabeler probot-autolabeler bot added API APIs related issues and PRs. Shop ShopBundle related issues and PRs. labels Nov 23, 2022
This was referenced Nov 28, 2022
Closed
Closed
Closed
@GSadee GSadee merged commit 37047d3 into Sylius:1.11 Dec 5, 2022
@GSadee
Copy link
Member

GSadee commented Dec 5, 2022

Thank you, Kevin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp approved these changes

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc. Shop ShopBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coldic3 @GSadee @diimpp @NoResponseMate