Product taxon position don't affect parent taxon - API #14577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
everwhatever
commented
Nov 25, 2022
everwhatever
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | ticket |
| License | MIT |
everwhatever
force-pushed
the
product-position-on-taxon-list-api
branch
from
9c657e6
to
ced383c
Compare
GSadee
reviewed
Nov 28, 2022
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Nov 29, 2022
...ures/product/viewing_products/viewing_product_from_specific_taxon_sorted_by_position.feature
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
coldic3
reviewed
Dec 7, 2022
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
...ius/Bundle/ApiBundle/spec/Doctrine/QueryCollectionExtension/ProductsByTaxonExtensionSpec.php
Outdated
Show resolved
Hide resolved
...ius/Bundle/ApiBundle/spec/Doctrine/QueryCollectionExtension/ProductsByTaxonExtensionSpec.php
Outdated
Show resolved
Hide resolved
coldic3
reviewed
Dec 7, 2022
...ius/Bundle/ApiBundle/spec/Doctrine/QueryCollectionExtension/ProductsByTaxonExtensionSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
coldic3
reviewed
Dec 7, 2022
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ProductsByTaxonExtension.php
Outdated
Show resolved
Hide resolved
everwhatever
force-pushed
the
product-position-on-taxon-list-api
branch
2 times, most recently
from
8707b29
to
b89b434
Compare
GSadee
approved these changes
Dec 8, 2022
src/Sylius/Bundle/ApiBundle/spec/Filter/Doctrine/TaxonFilterSpec.php
Outdated
Show resolved
Hide resolved
everwhatever
force-pushed
the
product-position-on-taxon-list-api
branch
from
b89b434
to
1faf03e
Compare
everwhatever
force-pushed
the
product-position-on-taxon-list-api
branch
4 times, most recently
from
59e5cad
to
b24d152
Compare
probot-autolabeler
bot
added
the
Maintenance
everwhatever
force-pushed
the
product-position-on-taxon-list-api
branch
2 times, most recently
from
c612c4e
to
43821ed
Compare
GSadee
reviewed
Jan 20, 2023
...res/product/viewing_products/viewing_products_from_specific_taxon_sorted_by_position.feature
Show resolved
Hide resolved
everwhatever
force-pushed
the
product-position-on-taxon-list-api
branch
from
1eb011a
to
ca44d0b
Compare
everwhatever
force-pushed
the
product-position-on-taxon-list-api
branch
from
ca44d0b
to
869dcae
Compare
GSadee
approved these changes
Jan 23, 2023
| Then I should see 3 products in the list | ||
| And they should have order like "Old pug", "Young pug" and "Small pug" | ||
|
|
||
| @ui | ||
| @ui @api |
There was a problem hiding this comment.
You are not consistent in the order of tags in this PR
|
Thank you, @everwhatever! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.