[ProductAssociation] Show product associations within current channel only

[coldic3]

Q	A
Branch?	1.11
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	fixes #14564
License	MIT

[NoResponseMate]

It seems we're missing a scenario where the associated product is available in a channel, but disabled.

[GSadee]

Thank you, Kevin! 🥇

[lruozzi9]

These changes contain a bug 😱!! The findWithProductsWithinChannel method should be allowed to return null:
public function findWithProductsWithinChannel($associationId, ChannelInterface $channel): ?ProductAssociationInterface;

This is also suggested by the getOneOrNullResult() method in the Doctrine implementation.

[coldic3]

@lruozzi9 Thanks for catching it! Indeed returning null should be allowed. Interesting why static analysis didn't catch it 🤔

[lruozzi9]

@coldic3 that's not the only problem. I now get the NotFoundHttpException from the findOr404 method while getting product associated from an empty association. Probably there is some error in the construction of the query.

[coldic3]

@lruozzi9 I see it! I did inner join instead of left join 🤦‍♂️ At first glance ProductAssociationRepository::findWithProductsWithinChannel should always return ProductAssociationInterface because we pass an ID as the first argument so I guess there is no way for returning null if the ID is correct. However, at least some assertion is needed.

[lruozzi9]

Right! 🤓😉