Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tag OrderTaxesApplicatorInterface #14623

Merged
merged 1 commit into from Mar 10, 2023
Merged

chore: tag OrderTaxesApplicatorInterface #14623

merged 1 commit into from Mar 10, 2023

Conversation

Florian-Merle
Copy link
Contributor

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Related tickets mentioned in #14609
License MIT

@Florian-Merle Florian-Merle requested a review from a team as a code owner December 7, 2022 19:58
@Florian-Merle Florian-Merle changed the title chore: tag OrderTaxesApplicatorInterface [WIP] chore: tag OrderTaxesApplicatorInterface Dec 7, 2022
@jakubtobiasz
Copy link
Member

Hi @Florian-Merle!
Is this PR still a WIP? It seems to be ready 🤔.

P.S. I let myself rebase it against latest changes from 1.13 branch :).

@Florian-Merle
Copy link
Contributor Author

Florian-Merle commented Jan 20, 2023 •
edited

Hi @jakubtobiasz ! Indeed it seems to be ready. Last time I worked on it the pipeline would fail but I did not take the time to search why 😅

@Florian-Merle Florian-Merle changed the title [WIP] chore: tag OrderTaxesApplicatorInterface chore: tag OrderTaxesApplicatorInterface Jan 20, 2023
@jakubtobiasz
Copy link
Member

Thanks! I'll wait for more approves/comments, and then I'll merge it :).

@GSadee GSadee added the DX Issues and PRs aimed at improving Developer eXperience. label Mar 10, 2023
@GSadee GSadee merged commit 7740d10 into Sylius:1.13 Mar 10, 2023
@GSadee
Copy link
Member

GSadee commented Mar 10, 2023

Thank you, Florian! 🎉

@GSadee GSadee mentioned this pull request Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Florian-Merle @jakubtobiasz @GSadee @NoResponseMate