[Fix][Shop] Conditional adding of logout listener #14625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Dec 8, 2022
NoResponseMate
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #14622 |
| License | MIT |
NoResponseMate
added
Shop
coldic3
approved these changes
Dec 9, 2022
mbabker
suggested changes
Dec 9, 2022
There was a problem hiding this comment.
This should make use of the firewall_context_name config node in the ShopBundle's config instead of continuing to hardcode the firewall name. This would ensure that the listener is correctly attached to whatever firewall is configured as the shop (frontend) firewall, regardless of name. Looking at the listener's functionality, I would say there are security implications if it isn't registered as expected.
mbabker
approved these changes
Dec 9, 2022
Rafikooo
approved these changes
Dec 12, 2022
jakubtobiasz
approved these changes
Dec 14, 2022
GSadee
approved these changes
Dec 15, 2022
|
Thank you, Jan! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.