[Feature] Allows row_attr on form rows
#14693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Prometee! |
Prometee
changed the title
row_attr on form rowsrow_attr on form rows
|
@jakubtobiasz sure ! It's done. |
jakubtobiasz
force-pushed
the
row-attr
branch
from
bb16d36
to
828ce8f
Compare
jakubtobiasz
approved these changes
Jan 16, 2023
Rafikooo
approved these changes
Jan 16, 2023
GSadee
approved these changes
Jan 18, 2023
| @@ -1,7 +1,14 @@ | |||
| {% extends 'form_div_layout.html.twig' %} | |||
|
|
|||
| {% block form_row -%} | |||
| <div class="{% if required %}required {% endif %}field{% if (not compound or force_error|default(false)) and not valid %} error{% endif %}"> | |||
| {% set row_attr=row_attr|merge({'class': row_attr.class|default ~ ' field'}) %} | |||
There was a problem hiding this comment.
Suggested change
| {% set row_attr=row_attr|merge({'class': row_attr.class|default ~ ' field'}) %} | |
| {% set row_attr = row_attr|merge({'class': row_attr.class|default ~ ' field'}) %} |
| <div class="{% if required %}required {% endif %}field{% if (not compound or force_error|default(false)) and not valid %} error{% endif %}"> | ||
| {% set row_attr=row_attr|merge({'class': row_attr.class|default ~ ' field'}) %} | ||
| {% if required %} | ||
| {% set row_attr=row_attr|merge({'class': row_attr.class|default ~ ' required'}) %} |
There was a problem hiding this comment.
Suggested change
| {% set row_attr=row_attr|merge({'class': row_attr.class|default ~ ' required'}) %} | |
| {% set row_attr = row_attr|merge({'class': row_attr.class|default ~ ' required'}) %} |
| {% set row_attr=row_attr|merge({'class': row_attr.class|default ~ ' required'}) %} | ||
| {% endif %} | ||
| {% if (not compound or force_error|default(false)) and not valid %} | ||
| {% set row_attr=row_attr|merge({'class': row_attr.class|default ~ ' error'}) %} |
There was a problem hiding this comment.
Suggested change
| {% set row_attr=row_attr|merge({'class': row_attr.class|default ~ ' error'}) %} | |
| {% set row_attr = row_attr|merge({'class': row_attr.class|default ~ ' error'}) %} |
|
Thank you, Francis! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use
row_attrof eachform_rowwhich wasn't possible with the current code.