Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error suppression to fix unit tests #14697

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Remove error suppression to fix unit tests #14697

merged 1 commit into from
Jan 11, 2023

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Jan 10, 2023 •
edited
Loading

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Last time ECS added the @ operator to the trigger_error call. Because of it, unit tests can't test if the deprecation works.

@coldic3 coldic3 requested a review from a team as a code owner January 10, 2023 13:42
@GSadee GSadee merged commit fe1ef60 into Sylius:1.11 Jan 11, 2023
@GSadee
Copy link
Member

GSadee commented Jan 11, 2023

Thanks, Kevin! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Rafikooo Rafikooo Rafikooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coldic3 @GSadee @Rafikooo