ApiBundle fixes in composer.js #14698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubtobiasz
requested changes
Jan 12, 2023
| @@ -44,7 +44,8 @@ | |||
| "symfony/dotenv": "^5.4 || ^6.0", | |||
| "symfony/http-client": "^5.4 || ^6.0", | |||
| "symfony/webpack-encore-bundle": "^1.15", | |||
| "theofidry/alice-data-fixtures": "^1.4" | |||
| "theofidry/alice-data-fixtures": "^1.4", | |||
| "ext-sqlite3": "*" | |||
There was a problem hiding this comment.
Keep alphabetical order please :).
There was a problem hiding this comment.
yes i see @jakubtobiasz, and fixed it
dawkaa
force-pushed
the
dev
branch
2 times, most recently
from
021bac0
to
24cbb1f
Compare
|
i rebased and pushed |
jakubtobiasz
approved these changes
Jan 16, 2023
Give exceptions, such as could not find a driver when commands create a test database. So I added the requirement in composer.js to fix it.
|
Thanks, @dawkaa! 🎉 |
|
😁😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give exceptions, such as could not find a driver when commands create a test database. So I added the requirement in composer.js to fix it.