Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unneeded @javascript tag #14709

Merged
merged 1 commit into from Jan 12, 2023
Merged

Drop unneeded @javascript tag #14709

merged 1 commit into from Jan 12, 2023

Conversation

jakubtobiasz
Copy link
Member

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
License MIT

Part of new CI, this tag was causing problems. We discovered we don't need it 🤷🏼‍♂️.

@jakubtobiasz jakubtobiasz added the Maintenance CI configurations, READMEs, releases, etc. label Jan 12, 2023
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner January 12, 2023 12:28
@GSadee GSadee added the Behat Issues and PRs aimed at improving Behat usage. label Jan 12, 2023
@Rafikooo Rafikooo merged commit 6442b53 into Sylius:1.13 Jan 12, 2023
@Rafikooo
Copy link
Contributor

Thank you, Jakub! 🥇

@jakubtobiasz jakubtobiasz deleted the new-ci/drop-javascript-tag-in-behat branch January 12, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@coldic3 coldic3 coldic3 approved these changes

@Rafikooo Rafikooo Rafikooo approved these changes

@TheMilek TheMilek TheMilek approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jakubtobiasz @Rafikooo @GSadee @NoResponseMate @coldic3 @TheMilek