[User] Allow configuring lastLogin tracking frequency
#14722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Jan 16, 2023
NoResponseMate
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | replaces #12603 |
| License | MIT |
GSadee
added
Enhancement
GSadee
reviewed
Jan 17, 2023
There was a problem hiding this comment.
The PR looks ok, but to be honest, I am not convinced to merge this change, especially to the 1.11. From my perspective, this is not a bug fix but an improvement or even a new functionality, so that it should be opened to the 1.13 branch.
I guess I would like to hear more opinions on this and the need for it, because while I understand the argument related to the API, the introduction of this parameter may lead to the information about the last login not really being true.
jakubtobiasz
approved these changes
Jan 26, 2023
GSadee
approved these changes
Jan 26, 2023
|
Thank you, @NoResponseMate! |
GSadee
added a commit
that referenced
this pull request
Jan 31, 2023
…ments (NoResponseMate) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | continues #14722 | | License | MIT | Commits ------- f657279 [UserBundle] Fix UserLastLoginSubscriber arguments a407e6a [Documentation][UserBundle] Add missing configuration nodes
NoResponseMate
deleted the
SYL-2554/config-user-last-login-frequency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.