Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Fix admin's side can't create new taxonomy #14728

Merged
merged 1 commit into from Feb 3, 2023
Merged

[API] Fix admin's side can't create new taxonomy #14728

merged 1 commit into from Feb 3, 2023

Conversation

dawkaa
Copy link
Contributor

@dawkaa dawkaa commented Jan 18, 2023 •
edited

I fixed the admin's side can't create new taxon.

Q A
Branch? 1.13
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@dawkaa dawkaa requested a review from a team as a code owner January 18, 2023 10:03
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Jan 18, 2023
@dawkaa dawkaa force-pushed the improving_taxon_api branch 2 times, most recently from 17f3340 to 70c9dc4 Compare January 19, 2023 06:14
@dawkaa dawkaa changed the title [API] Fix admin's side can't create new taxon [API] Fix admin's side can't create new taxonomy Jan 19, 2023
@dawkaa dawkaa force-pushed the improving_taxon_api branch 3 times, most recently from 11364ae to 4014962 Compare January 26, 2023 05:11
@jakubtobiasz jakubtobiasz self-assigned this Jan 26, 2023
@jakubtobiasz
Copy link
Member

Hi @dawkaa!
Thanks for your contribution!

Would you like to write a test covering this case (the PHPUnit API test case should be enough)? I know there's none currently, but it should protect us in the future. Thanks in advance. If you need any help, just let me know :).

@dawkaa
Copy link
Contributor Author

dawkaa commented Jan 26, 2023 •
edited

Hi @dawkaa! Thanks for your contribution!

Would you like to write a test covering this case (the PHPUnit API test case should be enough)? I know there's none currently, but it should protect us in the future. Thanks in advance. If you need any help, just let me know :).

Hi @jakubtobiasz Sure, I see.
Thanks for your reply. If there is something I don't know, I will ask.
I added the PHPUnit API test case for a new taxon, so again review, please.

@jakubtobiasz
Copy link
Member

@dawkaa I see after your force push the test disappeared.

@dawkaa
Copy link
Contributor Author

dawkaa commented Feb 2, 2023

@dawkaa I see after your force push the test disappeared.

Sorry, I pushed the PHPUnit API test case from my laptop and did a force push from my work laptop 6 hours ago, so I would re-push after returning home. 😄

@jakubtobiasz
Copy link
Member

@dawkaa cool, ping me when done. I'll ping the rest of team to review it :).

@dawkaa
[API] Fix admin's side can't create new taxon
13c1eec 
I fixed the admin's side can't create new taxon.
@jakubtobiasz jakubtobiasz merged commit ddb9083 into Sylius:1.13 Feb 3, 2023
@jakubtobiasz
Copy link
Member

Thank you, @dawkaa!

@dawkaa dawkaa deleted the improving_taxon_api branch February 3, 2023 07:29
@dawkaa
Copy link
Contributor Author

dawkaa commented Feb 3, 2023

Thank you, @dawkaa!

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees

@jakubtobiasz jakubtobiasz

Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dawkaa @jakubtobiasz @GSadee @NoResponseMate