Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.2 to workflows #14754

Merged
merged 1 commit into from Feb 3, 2023
Merged

Add PHP 8.2 to workflows #14754

merged 1 commit into from Feb 3, 2023

Conversation

jakubtobiasz
Copy link
Member

@jakubtobiasz jakubtobiasz commented Jan 26, 2023

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets successor of #14627
License MIT

This PR takes an idea from #14627 but is adjusted to our new CI 馃拑馃徎.

@jakubtobiasz jakubtobiasz requested a review from a team as a code owner January 26, 2023 09:03
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jan 26, 2023
@jakubtobiasz jakubtobiasz mentioned this pull request Jan 26, 2023
Comment on lines +70 to +73
- name: "Require ext-random"
if: matrix.php == '8.2'
run: composer require ext-random --no-update --no-scripts --no-interaction

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extension exists only in 8.2 and is required to be present to satisfy ComposerRequireCheck.

@jakubtobiasz jakubtobiasz changed the title 馃毀 Add PHP 8.2 to workflows Add PHP 8.2 to workflows Feb 2, 2023
@jakubtobiasz jakubtobiasz added the CI Issues and PRs related to automated testing label Feb 2, 2023
@GSadee GSadee merged commit 5ed82ba into Sylius:1.13 Feb 3, 2023
@GSadee
Copy link
Member

GSadee commented Feb 3, 2023

Thank you, Jakub! 馃

@jakubtobiasz jakubtobiasz deleted the ci/php-82 branch February 3, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues and PRs related to automated testing Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants