Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin][ProductOptions] Changed form ProductOptionChoiceType to Produ… #14806

Merged
merged 5 commits into from Aug 28, 2023
Merged

[Admin][ProductOptions] Changed form ProductOptionChoiceType to Produ… #14806

merged 5 commits into from Aug 28, 2023

Conversation

ulinskas
Copy link
Contributor

@ulinskas ulinskas commented Feb 13, 2023 •
edited by TheMilek

…ctOptionAutocompleteType

Q A
Branch? 1.12
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #13742
License MIT

Before:
image

After:
image

@ulinskas ulinskas requested a review from a team as a code owner February 13, 2023 04:00
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Feb 13, 2023
@jakubtobiasz
Copy link
Member

Hi @ulinskas!
This PR looks promising in terms of functionality. Would you like to fix Behat scenarios, as they're broken now? Meanwhile, I (or we) will analyze how much we break backward compatibility, as often removing any class is a bad sign.

@ulinskas
Copy link
Contributor Author

@jakubtobiasz I will try to fix Behat scenarios

@TheMilek
Copy link
Member

TheMilek commented Apr 7, 2023 •
edited

Hi @ulinskas! 🚀

Thank you for submitting the pull request
I just wanted to confirm if you are still working on it and planning to complete the changes 🍻

Please let us know if you have any questions or concerns 😄

@ulinskas
Copy link
Contributor Author

ulinskas commented Apr 7, 2023

@TheMilek
Yes, I do. I'm currently on a long running vacations, but getting back to work in 2 weeks. So I hope, in a 4-5 weeks period, I will be able to introduce a solution for the tests.

@Rafikooo
Copy link
Contributor

Hey @ulinskas,

This is a friendly reminder in case you forgot about it 😆

Best wishes,
Rafał

@TheMilek TheMilek force-pushed the issue-13742-admin-product-options branch from ecbef39 to 5876e42 Compare August 22, 2023 16:21
@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@TheMilek TheMilek force-pushed the issue-13742-admin-product-options branch 2 times, most recently from f7f6055 to 354eebe Compare August 23, 2023 08:02
@TheMilek TheMilek force-pushed the issue-13742-admin-product-options branch from 354eebe to 2fc92b3 Compare August 24, 2023 10:17
@TheMilek TheMilek added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Bug Confirmed bugs or bugfixes. labels Aug 24, 2023
@TheMilek TheMilek force-pushed the issue-13742-admin-product-options branch from 2fc92b3 to 3e9c137 Compare August 24, 2023 10:49
@jakubtobiasz
Copy link
Member

/bns:deploy

@TheMilek TheMilek force-pushed the issue-13742-admin-product-options branch 2 times, most recently from ec82de3 to acfb7e4 Compare August 25, 2023 11:54
@TheMilek TheMilek mentioned this pull request Aug 25, 2023
Merged
SzymonFilipek
SzymonFilipek approved these changes Aug 25, 2023
View reviewed changes
Copy link

@SzymonFilipek SzymonFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes passed QA check

@jakubtobiasz jakubtobiasz merged commit c30131f into Sylius:1.12 Aug 28, 2023
25 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @ulinskas!

@ulinskas ulinskas deleted the issue-13742-admin-product-options branch August 28, 2023 06:22
GSadee added a commit that referenced this pull request Sep 7, 2023
@GSadee
minor #15254 Deprecate unused ProductOptionChoiceType (TheMilek)
36be57b 
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 <!-- see the comment below -->                  |
| Bug fix?        | no                                                      |
| New feature?    | no                                                      |
| BC breaks?      | no                                                     |
| Deprecations?   | yes <!-- don't forget to update the UPGRADE-*.md file --> |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Followed by #14806

Commits
-------

cb653e0 Deprecate unused class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

@SzymonFilipek SzymonFilipek SzymonFilipek approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ulinskas @jakubtobiasz @TheMilek @Rafikooo @NoResponseMate @SzymonFilipek