Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat][API] Add "no-api" tag to the changing payment method page scenario #14939

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Apr 14, 2023

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

I mark this scenario as a no-api because in the API, "thank you" page with payment methods doesn't exist. There is a GET /api/v2/shop/payment-methods endpoint but it's independent of the order.

@coldic3 coldic3 added the API APIs related issues and PRs. label Apr 14, 2023
@coldic3 coldic3 requested a review from a team as a code owner April 14, 2023 14:59
@Rafikooo Rafikooo force-pushed the feature/having-good-number-of-items-in-changing-payment-method-page-api-coverage branch from 6501776 to fec60ff Compare April 18, 2023 09:39
@Rafikooo
Copy link
Contributor

I've rebased it due to failed tests 💃

@NoResponseMate NoResponseMate merged commit 114b6f7 into Sylius:1.13 Apr 18, 2023
23 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @coldic3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants