Cover inform customer about order total changes scenarios in API #14944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakubtobiasz
commented
Apr 15, 2023
jakubtobiasz
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | contains fixes from #14941 |
| License | MIT |
Rafikooo
reviewed
Apr 18, 2023
features/checkout/paying_for_order/inform_customer_about_order_total_changes.feature
Outdated
Show resolved
Hide resolved
features/checkout/paying_for_order/inform_customer_about_order_total_changes.feature
Outdated
Show resolved
Hide resolved
GSadee
requested changes
Apr 21, 2023
features/checkout/paying_for_order/inform_customer_about_order_total_changes.feature
Outdated
Show resolved
Hide resolved
jakubtobiasz
force-pushed
the
feature/api/SYL-2617-cover-inform-customer-about-order-total-changes-feature
branch
2 times, most recently
from
ddce6aa
to
6b0ff9f
Compare
probot-autolabeler
bot
added
API
jakubtobiasz
force-pushed
the
feature/api/SYL-2617-cover-inform-customer-about-order-total-changes-feature
branch
2 times, most recently
from
d5f27bc
to
ba440a0
Compare
jakubtobiasz
commented
Apr 28, 2023
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/CompleteOrderHandler.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Apr 28, 2023
features/checkout/paying_for_order/inform_customer_about_order_total_changes.feature
Outdated
Show resolved
Hide resolved
jakubtobiasz
force-pushed
the
feature/api/SYL-2617-cover-inform-customer-about-order-total-changes-feature
branch
from
73888d8
to
615d476
Compare
TheMilek
previously approved these changes
May 4, 2023
NoResponseMate
changed the title
jakubtobiasz
force-pushed
the
feature/api/SYL-2617-cover-inform-customer-about-order-total-changes-feature
branch
2 times, most recently
from
42bc8a2
to
7a0cbd8
Compare
coldic3
previously approved these changes
May 12, 2023
jakubtobiasz
force-pushed
the
feature/api/SYL-2617-cover-inform-customer-about-order-total-changes-feature
branch
from
1394478
to
55d9f7d
Compare
Rafikooo
previously approved these changes
May 15, 2023
src/Sylius/Bundle/ApiBundle/spec/CommandHandler/Checkout/CompleteOrderHandlerSpec.php
Outdated
Show resolved
Hide resolved
jakubtobiasz
force-pushed
the
feature/api/SYL-2617-cover-inform-customer-about-order-total-changes-feature
branch
from
55d9f7d
to
c0055eb
Compare
NoResponseMate
approved these changes
May 17, 2023
jakubtobiasz
force-pushed
the
feature/api/SYL-2617-cover-inform-customer-about-order-total-changes-feature
branch
from
c0055eb
to
2a77873
Compare
GSadee
approved these changes
May 18, 2023
|
Thank you, Jacob! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.