Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProductTaxon][Product] Improve validation #14989

Merged

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.13
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets related #14724
License MIT

@NoResponseMate NoResponseMate added API APIs related issues and PRs. Bug Confirmed bugs or bugfixes. labels Apr 26, 2023
@NoResponseMate NoResponseMate requested a review from a team as a code owner April 26, 2023 08:43
@NoResponseMate NoResponseMate force-pushed the SYL-2215/more-product-taxon-validation branch from b627577 to 8793f07 Compare April 26, 2023 10:58
}

/**
* @Then I should be notified that specifying a :part is required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @Then I should be notified that specifying a :part is required
* @Then I should be notified that specifying a :field is required

?

@GSadee GSadee merged commit c41bbe3 into Sylius:1.13 Apr 27, 2023
23 checks passed
@GSadee
Copy link
Member

GSadee commented Apr 27, 2023

Thanks, Jan! 🥇

@NoResponseMate NoResponseMate deleted the SYL-2215/more-product-taxon-validation branch September 22, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants