Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change prority for custom ChannelContext #15014

Merged
merged 1 commit into from Jun 1, 2023
Merged

Change prority for custom ChannelContext #15014

merged 1 commit into from Jun 1, 2023

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented May 4, 2023 •
edited

Q A
Branch? 1.12
Bug fix? yes (documentation)
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

ChannelContext priority is 0, not -128, see

Sylius/src/Sylius/Bundle/ChannelBundle/Resources/config/services.xml

Lines 43 to 47 in 8b130ff

<service id="sylius.context.channel.request_based" class="Sylius\Component\Channel\Context\RequestBased\ChannelContext" public="false">
<argument type="service" id="sylius.context.channel.request_based.resolver" />
<argument type="service" id="request_stack" />
<tag name="sylius.context.channel" />
</service>

@l-vo l-vo requested a review from a team as a code owner May 4, 2023 09:00
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label May 4, 2023
@GSadee GSadee merged commit ccc899d into Sylius:1.12 Jun 1, 2023
4 checks passed
@GSadee
Copy link
Member

GSadee commented Jun 1, 2023

Thanks, Laurent! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@l-vo @GSadee