New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintenance] Add a note about PostgreSQL migrations support #15043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rafikooo
commented
May 16, 2023
Q | A |
---|---|
Branch? | 1.13 |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | #14950 |
License | MIT |
NoResponseMate
approved these changes
May 17, 2023
jakubtobiasz
approved these changes
May 20, 2023
Thank you, @Rafikooo! |
jakubtobiasz
added a commit
that referenced
this pull request
Oct 11, 2023
This PR was merged into the 1.13 branch. Discussion ---------- Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | yes <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | #15050 #15043 #14950 | | License | MIT | The installation of Sylius 1.13 with PostgreSQL on board ended with the following error: <img width="1665" alt="image" src="https://github.com/Sylius/Sylius/assets/40125720/87b8e16c-a281-4bb3-9b99-b158ab67c9d1"> This PR resolves this issue Second, we removed checking: ```php if (method_exists($connection, 'createSchemaManager')) { return $connection->createSchemaManager(); } if (method_exists($connection, 'getSchemaManager')) { /** @psalm-suppress DeprecatedMethod */ return $connection->getSchemaManager(); } ``` as we no longer support `doctrine/dbal: 2.x` in `Sylius 1.13` Commits ------- [CoreBundle] Remove deprecated PostgreSQL platform check when installing Sylius [CoreBundle] Remove deprecated availability check of createSchemaManager method [CoreBundle] Add minor improvements for the DatabaseSetupCommandsProvider class [CoreBundle] Update the PostgreSQLDefaultSchemaListener class [ECS] Apply ecs fixes [Migrations] Remove deprecated availability check of createSchemaManager method [CoreBundle] Refactor the DatabaseSetupCommandsProvider class
GSadee
pushed a commit
to Sylius/SyliusCoreBundle
that referenced
this pull request
Oct 12, 2023
This PR was merged into the 1.13 branch. Discussion ---------- Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | yes <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | Sylius/Sylius#15050 Sylius/Sylius#15043 Sylius/Sylius#14950 | | License | MIT | The installation of Sylius 1.13 with PostgreSQL on board ended with the following error: <img width="1665" alt="image" src="https://github.com/Sylius/Sylius/assets/40125720/87b8e16c-a281-4bb3-9b99-b158ab67c9d1"> This PR resolves this issue Second, we removed checking: ```php if (method_exists($connection, 'createSchemaManager')) { return $connection->createSchemaManager(); } if (method_exists($connection, 'getSchemaManager')) { /** @psalm-suppress DeprecatedMethod */ return $connection->getSchemaManager(); } ``` as we no longer support `doctrine/dbal: 2.x` in `Sylius 1.13` Commits ------- [CoreBundle] Remove deprecated PostgreSQL platform check when installing Sylius [CoreBundle] Remove deprecated availability check of createSchemaManager method [CoreBundle] Add minor improvements for the DatabaseSetupCommandsProvider class [CoreBundle] Update the PostgreSQLDefaultSchemaListener class [ECS] Apply ecs fixes [Migrations] Remove deprecated availability check of createSchemaManager method [CoreBundle] Refactor the DatabaseSetupCommandsProvider class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.