Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][Installer] Install Sylius 1.12 with PostgreSQL #15050

Merged
merged 3 commits into from May 25, 2023
Merged

[Fix][Installer] Install Sylius 1.12 with PostgreSQL #15050

merged 3 commits into from May 25, 2023

Conversation

Rafikooo
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets #14950
License MIT

@Rafikooo Rafikooo added the Bug Confirmed bugs or bugfixes. label May 17, 2023
@Rafikooo Rafikooo requested a review from a team as a code owner May 17, 2023 15:54
@Rafikooo Rafikooo changed the title [Fix][Installer] Pass default fixture suite to the command [Fix][Installer] Install Sylius 1.12 with PostgreSQL May 17, 2023
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. labels May 22, 2023
@GSadee GSadee merged commit ef6b335 into Sylius:1.12 May 25, 2023
23 checks passed
@GSadee
Copy link
Member

GSadee commented May 25, 2023

Thanks, Rafał! 🥇

@Rafikooo Rafikooo mentioned this pull request Oct 11, 2023
Merged
jakubtobiasz added a commit that referenced this pull request Oct 11, 2023
@jakubtobiasz
minor #15425 [PostgreSQL] Sylius installation fix (Rafikooo)
5c43037 
This PR was merged into the 1.13 branch.

Discussion
----------

Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 <!-- see the comment below -->                  |
| Bug fix?        | yes                                                      |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | yes <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | #15050 #15043 #14950            |
| License         | MIT                                                          |

The installation of Sylius 1.13 with PostgreSQL on board ended with the following error:
<img width="1665" alt="image" src="https://github.com/Sylius/Sylius/assets/40125720/87b8e16c-a281-4bb3-9b99-b158ab67c9d1">
This PR resolves this issue

Second, we removed checking:
```php
if (method_exists($connection, 'createSchemaManager')) {
    return $connection->createSchemaManager();
}

if (method_exists($connection, 'getSchemaManager')) {
    /** @psalm-suppress DeprecatedMethod */
    return $connection->getSchemaManager();
}
```
as we no longer support `doctrine/dbal: 2.x` in `Sylius 1.13`

Commits
-------
  [CoreBundle] Remove deprecated PostgreSQL platform check when installing Sylius
  [CoreBundle] Remove deprecated availability check of createSchemaManager method
  [CoreBundle] Add minor improvements for the DatabaseSetupCommandsProvider class
  [CoreBundle] Update the PostgreSQLDefaultSchemaListener class
  [ECS] Apply ecs fixes
  [Migrations] Remove deprecated availability check of createSchemaManager method
  [CoreBundle] Refactor the DatabaseSetupCommandsProvider class
GSadee pushed a commit to Sylius/SyliusCoreBundle that referenced this pull request Oct 12, 2023
@jakubtobiasz
minor #15425 [PostgreSQL] Sylius installation fix (Rafikooo)
46d45f7 
This PR was merged into the 1.13 branch.

Discussion
----------

Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 <!-- see the comment below -->                  |
| Bug fix?        | yes                                                      |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | yes <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | Sylius/Sylius#15050 Sylius/Sylius#15043 Sylius/Sylius#14950            |
| License         | MIT                                                          |

The installation of Sylius 1.13 with PostgreSQL on board ended with the following error:
<img width="1665" alt="image" src="https://github.com/Sylius/Sylius/assets/40125720/87b8e16c-a281-4bb3-9b99-b158ab67c9d1">
This PR resolves this issue

Second, we removed checking:
```php
if (method_exists($connection, 'createSchemaManager')) {
    return $connection->createSchemaManager();
}

if (method_exists($connection, 'getSchemaManager')) {
    /** @psalm-suppress DeprecatedMethod */
    return $connection->getSchemaManager();
}
```
as we no longer support `doctrine/dbal: 2.x` in `Sylius 1.13`

Commits
-------
  [CoreBundle] Remove deprecated PostgreSQL platform check when installing Sylius
  [CoreBundle] Remove deprecated availability check of createSchemaManager method
  [CoreBundle] Add minor improvements for the DatabaseSetupCommandsProvider class
  [CoreBundle] Update the PostgreSQLDefaultSchemaListener class
  [ECS] Apply ecs fixes
  [Migrations] Remove deprecated availability check of createSchemaManager method
  [CoreBundle] Refactor the DatabaseSetupCommandsProvider class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rafikooo @GSadee @NoResponseMate