Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHPStan to level 5 #15059

Merged
merged 7 commits into from Jun 2, 2023
Merged

Upgrade PHPStan to level 5 #15059

merged 7 commits into from Jun 2, 2023

Conversation

lruozzi9
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially #14019
License MIT

@lruozzi9 lruozzi9 requested a review from a team as a code owner May 22, 2023 10:35
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Shop ShopBundle related issues and PRs. labels May 22, 2023
@lruozzi9 lruozzi9 mentioned this pull request May 22, 2023
8 tasks
jakubtobiasz
jakubtobiasz previously approved these changes May 31, 2023
NoResponseMate
NoResponseMate previously approved these changes May 31, 2023
@Rafikooo Rafikooo dismissed stale reviews from NoResponseMate and jakubtobiasz via 70577d2 May 31, 2023 13:47
@Rafikooo
Copy link
Contributor

Hey @lruozzi9,

I took the liberty of adding minor changes :)

Best regards 🚀,

Rafał

@Rafikooo Rafikooo merged commit b7bb02b into Sylius:1.12 Jun 2, 2023
23 checks passed
@Rafikooo
Copy link
Contributor

Rafikooo commented Jun 2, 2023

Thank you, @lruozzi9!

@lruozzi9 lruozzi9 deleted the phpstan-upgrade-5 branch June 2, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants