New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PHPStan to level 5 #15059
Merged
Merged
Upgrade PHPStan to level 5 #15059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lruozzi9
commented
May 22, 2023
Q | A |
---|---|
Branch? | 1.12 |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | partially #14019 |
License | MIT |
probot-autolabeler
bot
added
Admin
AdminBundle related issues and PRs.
API
APIs related issues and PRs.
Shop
ShopBundle related issues and PRs.
labels
May 22, 2023
jakubtobiasz
previously approved these changes
May 31, 2023
NoResponseMate
previously approved these changes
May 31, 2023
Rafikooo
dismissed stale reviews from NoResponseMate and jakubtobiasz
via
May 31, 2023 13:47
70577d2
Hey @lruozzi9, I took the liberty of adding minor changes :) Best regards 🚀, Rafał |
Rafikooo
force-pushed
the
phpstan-upgrade-5
branch
from
May 31, 2023 14:08
70577d2
to
cfa4cd1
Compare
jakubtobiasz
approved these changes
May 31, 2023
NoResponseMate
approved these changes
Jun 1, 2023
coldic3
approved these changes
Jun 2, 2023
Thank you, @lruozzi9! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.