[Orders][API] Validate endpoints #15064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafikooo
changed the title
Rafikooo
changed the title
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderStateValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/CheckoutCompletion/CartStateValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/CheckoutCompletion/CartStateValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/CheckoutCompletion/CartStateValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/CheckoutCompletion/CartStateValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/CheckoutCompletion/AddressedStateValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/CheckoutCompletion/AddressedStateValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Controller/DeleteOrderItemAction.php
Outdated
Show resolved
Hide resolved
vvasiloi
reviewed
Jun 26, 2023
src/Sylius/Bundle/ApiBundle/Controller/DeleteOrderItemAction.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Controller/Payment/GetPaymentConfiguration.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/translations/validators.en.yaml
Outdated
Show resolved
Hide resolved
| @@ -68,6 +68,7 @@ sylius: | |||
| order: | |||
| currency_code: | |||
| not_valid: The currency code you entered is invalid. | |||
| invalid_state_transition: 'Cannot complete as order is in a wrong state. Current: %currentState%. Possible transitions: %possibleTransitions%.' | |||
There was a problem hiding this comment.
If this is shown to the customer, then it needs some rewording to make it less technical.
There was a problem hiding this comment.
It is intended for developers, the question is whether I should put it in ApiBundle, since this message is API-oriented
…gn shipping method
jakubtobiasz
approved these changes
Jul 3, 2023
GSadee
approved these changes
Jul 5, 2023
| { | ||
| Assert::isInstanceOf($value, OrderTokenValueAwareInterface::class); | ||
|
|
||
| /** @var CheckoutCompletion $constraint */ |
There was a problem hiding this comment.
Shouldn't be needed as there is an assertion below
Suggested change
| /** @var CheckoutCompletion $constraint */ |
|
Thank you, Rafał! 🥇 |
Merged
jakubtobiasz
added a commit
that referenced
this pull request
Jul 5, 2023
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | #15064 | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [PHPStan] Add missing @param annotations [ECS] Apply ecs fixes [Units] Adjust checkout completion responses
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are missing validation of the order checkout process and some URI parameters across order endpoints