Remove deprecated EventSubscriberInterface #15083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
Maintenance
TheMilek
force-pushed
the
remove-deprecated-interface
branch
from
16bbfed
to
27012ad
Compare
jakubtobiasz
reviewed
Jun 7, 2023
| use Doctrine\Persistence\Event\LifecycleEventArgs; | ||
| use Sylius\Bundle\CoreBundle\PriceHistory\Processor\ProductLowestPriceBeforeDiscountProcessorInterface; | ||
| use Sylius\Component\Core\Model\ChannelPricingInterface; | ||
| use Sylius\Component\Core\Model\ChannelPricingLogEntryInterface; | ||
|
|
||
| final class ChannelPricingLogEntryEventSubscriber implements EventSubscriberInterface | ||
| final class ChannelPricingLogEntryEventListener |
There was a problem hiding this comment.
FYI this class has been introduced in 1.13 so it isn't a BC.
Just saying, as I missed that fact at the first glance 😅.
jakubtobiasz
approved these changes
Jun 7, 2023
TheMilek
changed the title
Rafikooo
approved these changes
Jun 7, 2023
Rafikooo
approved these changes
Jun 7, 2023
|
Thank you, @TheMilek! |
jakubtobiasz
added a commit
that referenced
this pull request
Jun 22, 2023
… upgrade file (TheMilek) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Related to #15083 changes Commits ------- Update upgrade file from 1.12 with PriceHistoryPlugin to Sylius 1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Sylius/Sylius/actions/runs/5198421404/jobs/9374520800