Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance][API] Fix ChangedItemQuantityInCart validator alias #15087

Merged
merged 2 commits into from Jun 22, 2023
Merged

[Maintenance][API] Fix ChangedItemQuantityInCart validator alias #15087

merged 2 commits into from Jun 22, 2023

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.13
Bug fix? somewhat
New feature? no
BC breaks? no?
Deprecations? no
Related tickets -
License MIT

@NoResponseMate NoResponseMate added Maintenance CI configurations, READMEs, releases, etc. API APIs related issues and PRs. labels Jun 8, 2023
@NoResponseMate NoResponseMate requested a review from a team as a code owner June 8, 2023 09:08
jakubtobiasz
jakubtobiasz previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@jakubtobiasz jakubtobiasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should mention this change in the API upgrade file 🤔.

@TheMilek TheMilek merged commit 324d690 into Sylius:1.13 Jun 22, 2023
23 checks passed
@TheMilek
Copy link
Member

Thanks, Jan! 🥇

@NoResponseMate NoResponseMate deleted the maintenance/fix-api-validator-alias branch September 22, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMilek TheMilek TheMilek approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NoResponseMate @TheMilek @jakubtobiasz