Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Promotion] Ignore coupon based promotions when when processing an order with no coupon #15088

Merged
merged 1 commit into from Jun 9, 2023
Merged

[Promotion] Ignore coupon based promotions when when processing an order with no coupon #15088

merged 1 commit into from Jun 9, 2023

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? somewhat
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #14983
License MIT

@NoResponseMate NoResponseMate added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jun 8, 2023
@NoResponseMate NoResponseMate requested a review from a team as a code owner June 8, 2023 11:18
@GSadee GSadee merged commit 75d8d1c into Sylius:1.12 Jun 9, 2023
23 checks passed
@GSadee
Copy link
Member

GSadee commented Jun 9, 2023

Thanks, Jan! 🥇

@GSadee GSadee mentioned this pull request Jun 9, 2023
Closed
@NoResponseMate NoResponseMate deleted the SYL-2920/fix-order-promotion-processing branch September 22, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NoResponseMate @GSadee