Cover Seeing payment method instructions behat API scenario #15092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Jun 12, 2023
TheMilek
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| License | MIT |
TheMilek
added
Behat
TheMilek
changed the title
TheMilek
force-pushed
the
SYL-2628
branch
2 times, most recently
from
655a8b5
to
f9ec599
Compare
features/checkout/paying_for_order/seeing_payment_method_instructions_on_thank_you_page.feature
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Jun 15, 2023
TheMilek
force-pushed
the
SYL-2628
branch
2 times, most recently
from
af6c960
to
183b8d8
Compare
NoResponseMate
previously approved these changes
Jun 15, 2023
GSadee
approved these changes
Jun 15, 2023
| Given I am a logged in customer | ||
| And I have product "PHP T-Shirt" in the cart | ||
| When I proceed selecting "Offline" payment method | ||
| And I confirm my order | ||
| Then I should see the thank you page | ||
| And I should be informed with "Offline" payment method instructions |
There was a problem hiding this comment.
Suggested change
| And I should be informed with "Offline" payment method instructions | |
| Then I should be informed with "Offline" payment method instructions |
|
Thanks, Kamil! 🥇 |
Merged
GSadee
added a commit
that referenced
this pull request
Jun 15, 2023
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> fixes of #15068 and #15092 comments Commits ------- fc0969c Fixes after reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.