Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include children taxons while executing InForTaxonsScopeVariantChecker #15110

Merged
merged 3 commits into from Jun 23, 2023
Merged

Include children taxons while executing InForTaxonsScopeVariantChecker #15110

merged 3 commits into from Jun 23, 2023

Conversation

jakubtobiasz
Copy link
Member

@jakubtobiasz jakubtobiasz commented Jun 21, 2023 •
edited

Q A
Branch? 1.12
Bug fix? yes
New feature? no
BC breaks? no
License MIT

@jakubtobiasz jakubtobiasz added the Bug Confirmed bugs or bugfixes. label Jun 21, 2023
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner June 21, 2023 10:43
@jakubtobiasz jakubtobiasz changed the title [CS][DX] Refactor Include children taxons while executing InForTaxonsScopeVariantChecker Jun 21, 2023
TheMilek
TheMilek previously approved these changes Jun 22, 2023
View reviewed changes
@jakubtobiasz jakubtobiasz dismissed stale reviews from TheMilek and Rafikooo via d886c14 June 22, 2023 13:27
@Rafikooo Rafikooo merged commit 45bc408 into Sylius:1.12 Jun 23, 2023
23 checks passed
@Rafikooo
Copy link
Contributor

Thank you, @jakubtobiasz!

@jakubtobiasz jakubtobiasz deleted the bug/SYL-2911 branch June 23, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafikooo Rafikooo Rafikooo approved these changes

@TheMilek TheMilek TheMilek left review comments

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubtobiasz @Rafikooo @TheMilek