Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Fix CommandDenormalizer ignoring custom property names #15165

Merged
merged 1 commit into from Jul 19, 2023
Merged

[API] Fix CommandDenormalizer ignoring custom property names #15165

merged 1 commit into from Jul 19, 2023

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

The CommandDenormalizer was ignoring custom serialized names when checking for required constructor argument so, for a mapping like:

<attribute name="productCode" serialized-name="product" />

and request data

{ product: 'some-code' }

we would get a MissingConstructorArgumentsException, while it's perfectly fine for the serializer

@NoResponseMate NoResponseMate requested a review from a team as a code owner July 14, 2023 09:35
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Jul 14, 2023
@NoResponseMate NoResponseMate force-pushed the fix/api-command-denormalizer-property-names-handling branch from 6673909 to 177beb4 Compare July 14, 2023 09:42
@NoResponseMate NoResponseMate force-pushed the fix/api-command-denormalizer-property-names-handling branch from 177beb4 to 5b23529 Compare July 14, 2023 09:46
@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@NoResponseMate NoResponseMate added the Bug Confirmed bugs or bugfixes. label Jul 14, 2023
@TheMilek TheMilek merged commit d00f340 into Sylius:1.12 Jul 19, 2023
25 checks passed
@TheMilek
Copy link
Member

Thanks, Jan! 🥇

@NoResponseMate NoResponseMate deleted the fix/api-command-denormalizer-property-names-handling branch September 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMilek TheMilek TheMilek approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NoResponseMate @TheMilek @jakubtobiasz