Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Order] Extract payments removal from OrderPaymentProcessor #15187

Merged
merged 4 commits into from Aug 3, 2023
Merged

[Order] Extract payments removal from OrderPaymentProcessor #15187

merged 4 commits into from Aug 3, 2023

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? yes
New feature? kinda
BC breaks? no
Deprecations? no
Related tickets fixes #11927, related #12437
License MIT

@NoResponseMate NoResponseMate added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. Bug Confirmed bugs or bugfixes. labels Jul 28, 2023
@NoResponseMate NoResponseMate requested a review from a team as a code owner July 28, 2023 14:16
@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@NoResponseMate NoResponseMate force-pushed the fix/extract-payment-removal-during-processing branch from 5a403b0 to c8c956c Compare August 2, 2023 14:01
jakubtobiasz
jakubtobiasz previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@jakubtobiasz jakubtobiasz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention the constructor change in the UPGRADE file, and it'd be perfect 🫶🏼

@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Aug 2, 2023
@GSadee GSadee merged commit 01048bd into Sylius:1.12 Aug 3, 2023
25 checks passed
@GSadee
Copy link
Member

GSadee commented Aug 3, 2023

Thank you, Jan! 🎉

@NoResponseMate NoResponseMate mentioned this pull request Aug 4, 2023
Merged
jakubtobiasz added a commit that referenced this pull request Aug 8, 2023
@jakubtobiasz
minor #15209 [Maintenance] Trigger deprecations in OrderPaymentProces…
d0d7077 
…sor (NoResponseMate)

This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 |
| Bug fix?        | no                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | yes |
| Related tickets | #15187                      |
| License         | MIT                                                          |

Commits
-------
  [Maintenance] Trigger deprecations in OrderPaymentProcessor
@NoResponseMate NoResponseMate deleted the fix/extract-payment-removal-during-processing branch September 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NoResponseMate @GSadee @jakubtobiasz