Fix configuring amount for catalog promotions fixed discount actions #15214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
Maintenance
Bunnyshell Preview Environment deletedAvailable commands:
|
jakubtobiasz
reviewed
Aug 7, 2023
Comment on lines
+29
to
+31
| 'constraints' => [ | ||
| new Type(['type' => 'numeric', 'groups' => ['sylius']]), | ||
| ], |
There was a problem hiding this comment.
I'm wondering maybe the groups option should be passed through the constructor. Now it cannot be easily changed, as you need to remove, and add a given field.
GSadee
approved these changes
Aug 10, 2023
| Given the store operates on a single channel in "United States" | ||
| And I am logged in as an administrator | ||
|
|
||
| @ui @no-api @javascript |
There was a problem hiding this comment.
Suggested change
| @ui @no-api @javascript | |
| @no-api @ui @javascript |
or
Suggested change
| @ui @no-api @javascript | |
| @ui @javascript @no-api |
🤔
| @@ -0,0 +1,20 @@ | |||
| @managing_catalog_promotions | |||
| Feature: Adding a new catalog promotion with fixed discount where amount is a decimal number with comma | |||
There was a problem hiding this comment.
This scenario could be added as an additional one to the feature for creating catalog promotions as the purpose is IMO the same, there is no need to create a separate feature file for that.
|
Thank you, Kamil! 🥇 |
GSadee
added a commit
that referenced
this pull request
Sep 14, 2023
… discount actions (TheMilek, NoResponseMate) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 <!-- see the comment below --> | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Same issue like [here](#15214) Commits ------- 92562de Fix configuring amount for cart promotions item percentage discount actions eb13a29 [Behat][Promotion] Update percentage decimal places tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is now possible to configure decimal amounts with comma without validation errors