Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit mapping between product and reviews, and between product and attributes #15221

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Aug 11, 2023

Q A
Branch? 1.13
Bug fix? yes?
New feature? no
BC breaks? no?
Deprecations?
Related tickets
License MIT

Due to problems with customising mappings in end applications, as subscribers are called at the very end, I declared explicitly the relationship between product and reviews and between product and attributes in XML mappings. Subscribers thus do not add these relationships, as they already exist.

@GSadee GSadee added the DX Issues and PRs aimed at improving Developer eXperience. label Aug 11, 2023
@GSadee GSadee requested a review from a team as a code owner August 11, 2023 13:26
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Aug 11, 2023
@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz jakubtobiasz merged commit 9ac0c7e into Sylius:1.13 Aug 12, 2023
25 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @GSadee!

@GSadee GSadee deleted the SYL-2842/improve-product-review-and-attribute-mappings branch August 14, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants