Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin][Product] Add language names to attribute values #15255

Merged
merged 1 commit into from Aug 28, 2023
Merged

[Admin][Product] Add language names to attribute values #15255

merged 1 commit into from Aug 28, 2023

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? yes?
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

Existing attributes

Before
Screenshot 2023-08-25 at 14 14 18
After
Screenshot 2023-08-25 at 14 43 32

Newly added attributes

Before
Screenshot 2023-08-25 at 14 23 31
After
Screenshot 2023-08-25 at 14 43 47

@NoResponseMate NoResponseMate requested a review from a team as a code owner August 25, 2023 12:50
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@SzymonFilipek
Copy link

/bns:deploy

SzymonFilipek
SzymonFilipek approved these changes Aug 28, 2023
View reviewed changes
Copy link

@SzymonFilipek SzymonFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes passed QA check

@jakubtobiasz jakubtobiasz merged commit 91f642a into Sylius:1.12 Aug 28, 2023
25 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @NoResponseMate!

@NoResponseMate NoResponseMate deleted the SYL-2900/show-language-name-on-attributes-forms branch January 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMilek TheMilek TheMilek approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

@SzymonFilipek SzymonFilipek SzymonFilipek approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NoResponseMate @SzymonFilipek @jakubtobiasz @TheMilek