Update default Rules of cart promotion #15263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zairigimad
commented
Aug 30, 2023
zairigimad
commented
| Q | A |
|---|---|
| Branch? | 1.12 or 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
probot-autolabeler
bot
added
the
Documentation
Prometee
previously approved these changes
Aug 30, 2023
NoResponseMate
previously approved these changes
Aug 30, 2023
Co-authored-by: Jan Góralski <jan.wojciech.goralski@gmail.com>
zairigimad
dismissed stale reviews from NoResponseMate and Prometee
via
61c1fc0
Bunnyshell Preview Environment deletedAvailable commands:
|
diimpp
previously approved these changes
Sep 14, 2023
| @@ -62,6 +62,8 @@ The types of rules that are configured in **Sylius** by default are: | |||
| * **Items From Taxon Total** - checks in the cart if items from a given taxon cost a given amount of money, | |||
| * **Nth Order** - checks if this is for example the second order made by the customer, | |||
| * **Shipping Country** - checks if the order's shipping address is in a given country. | |||
| * **Customer Group** - checks if the current customer is in a given customer group. | |||
| * **Contains Product** - checks if the order contains a certain product. | |||
There was a problem hiding this comment.
Would be cool to sort rules the same way as in the admin panel
Some of the rules no longer match admin panel (Not needed captial letters at each word for rest),
--- Taxon
--- Items From Taxon Total
+++ Has at least one from taxons
+++ Total price of items from taxonCart quantity
Customer group
Nth order
Shipping country
Has at least one from taxons
Total price of items from taxon
Contains product
Item total
@zairigimad Hi, great catch 👍 Please let me know if you would like to handle this, or I will do a follow up PR.
There was a problem hiding this comment.
Nice catch too @diimpp I can add it if you want in this PR since it’s not merged yet.
There was a problem hiding this comment.
That would be awesome, I'll raise this PR for faster merge afterwards.
Sorry for a long wait 🙏
diimpp
approved these changes
Sep 17, 2023
jakubtobiasz
approved these changes
Sep 17, 2023
|
Thank you, @zairigimad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.